Strict iterator_to_array, do not overwite duplicate keys #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookyman
force-pushed
the
iterator-to-array-strict
branch
from
ef63534 to
533f578
Compare
lookyman
force-pushed
the
iterator-to-array-strict
branch
from
533f578 to
ce5460e
Compare
|
Doesn't really make sense to me. This would effectively kill ALL maps and first class collections. 👎 from me. |
|
Hmm now that I think about it, this is actually trickier than I thought. You don't lose the items, but you do lose the keys, which might be important. Thank you @Majkl578! |
|
You definitely lose keys and you may lose items if there are duplicate keys (then last one wins). But generally this is similar i.e. to |
|
Agreed, closing this 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has shot us in a foot a couple times, especially when
yieldingfroman inner generator inside a generator.